Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support simultaneous create diff for same parent snapshot #7204

Merged

Conversation

cosmoer
Copy link
Contributor

@cosmoer cosmoer commented Jul 23, 2022

In CreateDiff function, we wil create view snapshot base on parent snapshot,
view snapshot name is "<parent snapshot KEY>-parent-view",

so while, It does not support concurrent operations,other user will be return to the error that the snapshot already exists.

So, we add uniquePart() as a suffix.

@k8s-ci-robot
Copy link

Hi @cosmoer. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cosmoer cosmoer force-pushed the fix-support-simultaneous-create-diff branch from 2dfe33d to b695622 Compare July 24, 2022 01:07
Signed-off-by: Qian Zhang <cosmoer@qq.com>
@cosmoer cosmoer force-pushed the fix-support-simultaneous-create-diff branch from b695622 to 344431c Compare July 24, 2022 01:35
@dmcgowan dmcgowan added this to New in Code Review via automation Jul 27, 2022
@dmcgowan dmcgowan moved this from New to Ready For Review in Code Review Jul 27, 2022
Copy link
Member

@dcantah dcantah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fuweid fuweid merged commit 8a6ea4b into containerd:main Jul 29, 2022
Code Review automation moved this from Ready For Review to Done Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

None yet

6 participants