[release 1.5 backport] Fix cleanup in critest #7275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Maksym Pavlenko <pavlenko.maksym@gmail.com>
samuelkarp
approved these changes
Aug 9, 2022
thaJeztah
approved these changes
Aug 9, 2022
| @@ -473,6 +473,14 @@ jobs: | |||
| TEST_RUNTIME: ${{ matrix.runtime }} | |||
| run: | | |||
| BDIR="$(mktemp -d -p $PWD)" | |||
|
|
|||
| function cleanup() { | |||
There was a problem hiding this comment.
Wondering if an if: always() would've worked for these (I see we're already using that for some steps below), or is the containerd process already killed by github actions itself on failure?
There was a problem hiding this comment.
Yeah. Checked the doc and we can have cleanup in the following step with always. Let's handle it in next pr👍
fuweid
approved these changes
Aug 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #7232
Signed-off-by: Maksym Pavlenko pavlenko.maksym@gmail.com