Runtime cleanup (Shim manager and task service) #7280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Maksym Pavlenko <pavlenko.maksym@gmail.com>
Signed-off-by: Maksym Pavlenko <pavlenko.maksym@gmail.com>
dmcgowan
approved these changes
Aug 12, 2022
|
Thanks for generalizing the shim manager and providing a way to get access to the ttrpc client. It also seems like a suitable use for generics to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a follow up for shim changes #5918 and addresses this todo.
It further decouples
ShimManagerandTaskService, so now shim manager is not aware aboutTaskServiceor any other service shim provides. Instead it manages generic shims instances, that can implement arbitrary number of services and just exposes a TTRPC client to them (viaShimInstanceinterface).Previously it was challenging to make this change because of
TaskListv1 dependency (v1 needs a list of Tasks while v2 needs a list of Shims). Since we updated supported Go versions (1.18, 1.19), which both support generics, we can implement multiple variations ofTaskList-NSMap[runtime.Task]forv1andNSMap[ShimInstance]forv2.