Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update k8s.io/cri-api to v0.25.0 #7287

Merged
merged 2 commits into from Aug 26, 2022
Merged

Update k8s.io/cri-api to v0.25.0 #7287

merged 2 commits into from Aug 26, 2022

Conversation

zouyee
Copy link
Contributor

@zouyee zouyee commented Aug 13, 2022

This version contains the CRI changes for checkpoint, resource in place update and events support.
Future patches will use the new fields in the CRI.

Signed-off-by: zounengren zouyee1989@gmail.com

@k8s-ci-robot
Copy link

Hi @zouyee. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@zouyee
Copy link
Contributor Author

zouyee commented Aug 14, 2022

reading https://gopkg.in/yaml.v2?go-get=1: 502 Bad Gateway

@k8s-ci-robot
Copy link

@zouyee: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@zouyee
Copy link
Contributor Author

zouyee commented Aug 14, 2022

server response: Cannot obtain refs from GitHub: cannot talk to GitHub: Get https://github.com/go-yaml/yaml.git/info/refs?service=git-upload-pack: net/http: request canceled (Client.Timeout exceeded while awaiting headers)

replace direct with GOPROXY

@zouyee zouyee marked this pull request as ready for review August 14, 2022 08:52
@zouyee
Copy link
Contributor Author

zouyee commented Aug 14, 2022

@dmcgowan dmcgowan added this to New in Code Review via automation Aug 15, 2022
@dmcgowan dmcgowan moved this from New to Ready For Review in Code Review Aug 15, 2022
@dmcgowan
Copy link
Member

If multiple PRs are hitting the proxy issue, might be worth splitting it into a separate PR. That is a much faster review.

@zouyee
Copy link
Contributor Author

zouyee commented Aug 19, 2022

If multiple PRs are hitting the proxy issue, might be worth splitting it into a separate PR. That is a much faster review.

@zouyee zouyee closed this Aug 19, 2022
Code Review automation moved this from Ready For Review to Done Aug 19, 2022
@zouyee zouyee deleted the cri-25 branch August 19, 2022 11:00
@zouyee zouyee restored the cri-25 branch August 19, 2022 11:01
@zouyee zouyee reopened this Aug 19, 2022
Code Review automation moved this from Done to New Aug 19, 2022
@zouyee zouyee changed the title Update k8s.io/cri-api to v0.25.0-rc.0 Update k8s.io/cri-api to v0.25.0 Aug 19, 2022
@zouyee zouyee marked this pull request as draft August 19, 2022 23:14
@samuelkarp
Copy link
Member

Can you rebase this on the current tip of main?

Signed-off-by: zounengren <zouyee1989@gmail.com>
Signed-off-by: zounengren <zouyee1989@gmail.com>
@zouyee zouyee marked this pull request as ready for review August 25, 2022 13:32
@zouyee
Copy link
Contributor Author

zouyee commented Aug 25, 2022

Can you rebase this on the current tip of main?

done

@dmcgowan dmcgowan moved this from New to Ready For Review in Code Review Aug 25, 2022
Copy link
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@estesp estesp merged commit 827b3a1 into containerd:main Aug 26, 2022
Code Review automation moved this from Ready For Review to Done Aug 26, 2022
@zouyee zouyee deleted the cri-25 branch August 27, 2022 02:08
@mikebrow mikebrow added this to the 1.6.9 milestone Sep 20, 2022
@mikebrow mikebrow added the cherry-pick/1.6.x Change to be cherry picked to release/1.6 branch label Sep 20, 2022
@samuelkarp samuelkarp added cherry-picked/1.6.x PR commits are cherry-picked into release/1.6 branch and removed cherry-pick/1.6.x Change to be cherry picked to release/1.6 branch labels Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-picked/1.6.x PR commits are cherry-picked into release/1.6 branch needs-ok-to-test
Projects
Development

Successfully merging this pull request may close these issues.

None yet

6 participants