Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[do not merge] test image-spec with embedded Platform #7382

Closed
wants to merge 1 commit into from

Conversation

thaJeztah
Copy link
Member

@k8s-ci-robot
Copy link

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@thaJeztah thaJeztah force-pushed the embed_platform branch 2 times, most recently from 0f0d0af to 5f0d079 Compare September 8, 2022 17:57
@thaJeztah
Copy link
Member Author

Ah, yes, some changes needed if struct literals are used;

# github.com/containerd/containerd/integration/client [github.com/containerd/containerd/integration/client.test]
Error: .\import_test.go:386:3: unknown field 'OS' in struct literal of type "github.com/opencontainers/image-spec/specs-go/v1".Image
Error: .\import_test.go:387:3: unknown field 'Architecture' in struct literal of type "github.com/opencontainers/image-spec/specs-go/v1".Image

Testing the "embed_platform" branch from:
opencontainers/image-spec#949

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Comment on lines +81 to +83
// FIXME: testing "embed_platform" branch from https://github.com/opencontainers/image-spec/pull/949
replace github.com/opencontainers/image-spec => github.com/thaJeztah/image-spec v1.0.2-0.20220908165244-ca2e500b1693

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// FIXME: testing "embed_platform" branch from https://github.com/opencontainers/image-spec/pull/949
replace github.com/opencontainers/image-spec => github.com/thaJeztah/image-spec v1.0.2-0.20220908165244-ca2e500b1693

👀

@tianon
Copy link
Member

tianon commented Dec 16, 2022

I've rolled the updated version of this change into #7376, so unless @thaJeztah objects to what I've done, this is probably safe to close 👀

@thaJeztah
Copy link
Member Author

superseded by #8498

@thaJeztah thaJeztah closed this May 10, 2023
Code Review automation moved this from New to Done May 10, 2023
@thaJeztah thaJeztah deleted the embed_platform branch May 10, 2023 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants