-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[do not merge] test image-spec with embedded Platform #7382
Conversation
thaJeztah
commented
Sep 8, 2022
- Testing the "embed_platform" branch from: Embed Platform in Image opencontainers/image-spec#949
- Relates to Fix several conversions of "ocispec.Image" to "ocispec.Platform" #7376 (comment)
Skipping CI for Draft Pull Request. |
0f0d0af
to
5f0d079
Compare
Ah, yes, some changes needed if struct literals are used;
|
Testing the "embed_platform" branch from: opencontainers/image-spec#949 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
5f0d079
to
ab663a7
Compare
// FIXME: testing "embed_platform" branch from https://github.com/opencontainers/image-spec/pull/949 | ||
replace github.com/opencontainers/image-spec => github.com/thaJeztah/image-spec v1.0.2-0.20220908165244-ca2e500b1693 | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// FIXME: testing "embed_platform" branch from https://github.com/opencontainers/image-spec/pull/949 | |
replace github.com/opencontainers/image-spec => github.com/thaJeztah/image-spec v1.0.2-0.20220908165244-ca2e500b1693 |
👀
I've rolled the updated version of this change into #7376, so unless @thaJeztah objects to what I've done, this is probably safe to close 👀 |
superseded by #8498 |