Add NoSameOwner option when unpacking tars #7386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When unpacking a TAR archive, containerd preserves file's owner: https://github.com/containerd/containerd/blob/main/archive/tar.go#L384 In some cases this behavior is not desired. In current implementation we avoid `Lchown` on Windows. Another case when this should be skipped is when using native snapshotter on darwin and running as non-root user. This PR extracts a generic option - `WithNoSameOwner` (same as `tar --no-same-owner`) to skip `Lchown` when its not required. Signed-off-by: Maksym Pavlenko <pavlenko.maksym@gmail.com>
dmcgowan
approved these changes
Sep 10, 2022
samuelkarp
approved these changes
Sep 10, 2022
AkihiroSuda
reviewed
Sep 11, 2022
| @@ -38,7 +38,7 @@ import ( | |||
| "github.com/containerd/containerd/mount" | |||
| "github.com/containerd/containerd/platforms" | |||
| "github.com/containerd/containerd/plugin" | |||
| digest "github.com/opencontainers/go-digest" | |||
AkihiroSuda
reviewed
Sep 11, 2022
| @@ -27,7 +27,7 @@ import ( | |||
| "io" | |||
| "time" | |||
|
|
|||
| winio "github.com/Microsoft/go-winio" | |||
| "github.com/Microsoft/go-winio" | |||
This was referenced Feb 25, 2023
This was referenced Mar 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When unpacking a TAR archive, containerd preserves file's owner: https://github.com/containerd/containerd/blob/main/archive/tar.go#L384
In some cases this behavior is not desired. In current implementation we avoid
Lchownon Windows. Another case when this should be skipped is when using native snapshotter on darwin and running as non-root user.This PR extracts a generic option -
WithNoSameOwner(same astar --no-same-owner) to skipLchownwhen its not required.Signed-off-by: Maksym Pavlenko pavlenko.maksym@gmail.com