-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/1.5] Setup pod network after creating the sandbox container #7464
[release/1.5] Setup pod network after creating the sandbox container #7464
Conversation
Hi @qiutongs. Thanks for your PR. I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
0307ab8
to
3cf005e
Compare
/ok-to-test |
With #7578 merged it'd be good to bring the failpoint-based tests over to this PR. |
3cf005e
to
b96bedf
Compare
f136e13
to
5fe264a
Compare
5fe264a
to
6ddc775
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
We should merge it after rollout 1.5.14 release
@fuweid 1.5.14 went out earlier this week so I assume this is safe to merge? |
Oops! I miss the release. Yes! It is safe to merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM other than the nit about commit history and the errors.Wrap
/fmt.Errorf
change.
6ddc775
to
2160dea
Compare
…nPodNetwork Signed-off-by: Qiutong Song <songqt01@gmail.com>
2160dea
to
0db865d
Compare
pull-containerd-node-e2e
v1 is expected to be not implemented. |
/retest |
/retest |
The tests still fail in the https://testgrid.k8s.io/sig-node-containerd#pull-containerd-node-e2e-1-5 |
/retest |
@qiutongs: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Hi @qiutongs . I am looking into the failure of the new job. Seems like the conformance tests are failing. |
/retest |
@qiutongs All the tests has passed . The |
Backport #7456 and #7505 to 1.5.