Make tests on GitHub less noisy #7530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping CI for Draft Pull Request. |
kzys
force-pushed
the
critest-ginkgo-v2
branch
7 times, most recently
from
6e836df
to
3edebb7
Compare
kzys
force-pushed
the
critest-ginkgo-v2
branch
from
3edebb7
to
69e1f65
Compare
v2 uses Node.js 12.x which is EOL. Signed-off-by: Kazuyoshi Kato <katokazu@amazon.com>
This version up will migrate critools off from Ginkgo 1.x which has been deprecated. Signed-off-by: Kazuyoshi Kato <katokazu@amazon.com>
`::group::` groups containerd logs by default. https://docs.github.com/en/actions/using-workflows/workflow-commands-for-github-actions#grouping-log-lines Signed-off-by: Kazuyoshi Kato <katokazu@amazon.com>
Signed-off-by: Kazuyoshi Kato <katokazu@amazon.com>
kzys
force-pushed
the
critest-ginkgo-v2
branch
from
69e1f65
to
8e7ef89
Compare
samuelkarp
approved these changes
Oct 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves containerd's testing on GitHub actions, especially around reporting.
The first two commits were upgrading dependencies to reduce version-related warnings. The rest is giving more structures around logging to help developers distinguish which logs are coming from which components.