-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support default hosts.toml configuration #7607
Conversation
Hi @jess-sol. Thanks for your PR. I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update https://github.com/containerd/containerd/blob/main/docs/hosts.md as well.
The change looks good. If we are going to build it into the default directory path logic then it could be ideal to choose a default directory which isn't also a valid domain name, such as |
Add support for an optional `default` registry hosts config, should no other hosts config match. Signed-off-by: Jess <jess@ros.io>
Signed-off-by: Jess <jess@ros.io>
Yeah that's a good point, I hadn't really considered bare hostnames when I named it; updated! |
Add support for an optional
default
registry hosts config, should no other hosts config match. Discussed in #7597