Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate proto services with go-ttrpc #7609

Merged
merged 2 commits into from Feb 22, 2024

Conversation

dmcgowan
Copy link
Member

This provides go bindings for our services using go-ttrpc and shares the same types used for existing grpc services.

@k8s-ci-robot
Copy link

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@dmcgowan dmcgowan force-pushed the generate-ttrpc-services branch 3 times, most recently from 552e9b5 to 0b104cd Compare October 31, 2022 22:21
@dmcgowan dmcgowan added this to New in Code Review via automation Nov 18, 2022
@dmcgowan dmcgowan force-pushed the generate-ttrpc-services branch 2 times, most recently from da799ae to 5ad0d40 Compare December 23, 2022 01:44
Signed-off-by: Derek McGowan <derek@mcg.dev>
Signed-off-by: Derek McGowan <derek@mcg.dev>
@dmcgowan dmcgowan removed this from New in Code Review Feb 21, 2024
@dmcgowan dmcgowan added this to the 2.0 milestone Feb 21, 2024
@dmcgowan dmcgowan marked this pull request as ready for review February 21, 2024 22:28
Copy link
Member

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mxpv mxpv added this pull request to the merge queue Feb 22, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 22, 2024
@mxpv mxpv added this pull request to the merge queue Feb 22, 2024
Merged via the queue into containerd:main with commit 65588b5 Feb 22, 2024
47 checks passed
@dmcgowan dmcgowan deleted the generate-ttrpc-services branch April 20, 2024 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

None yet

5 participants