New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate proto services with go-ttrpc #7609
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Skipping CI for Draft Pull Request. |
dmcgowan
force-pushed
the
generate-ttrpc-services
branch
3 times, most recently
from
October 31, 2022 22:21
552e9b5
to
0b104cd
Compare
dmcgowan
force-pushed
the
generate-ttrpc-services
branch
2 times, most recently
from
December 23, 2022 01:44
da799ae
to
5ad0d40
Compare
dmcgowan
force-pushed
the
generate-ttrpc-services
branch
from
February 21, 2024 22:20
5ad0d40
to
765af5f
Compare
Signed-off-by: Derek McGowan <derek@mcg.dev>
Signed-off-by: Derek McGowan <derek@mcg.dev>
dmcgowan
force-pushed
the
generate-ttrpc-services
branch
from
February 21, 2024 22:22
765af5f
to
f0e8749
Compare
fuweid
approved these changes
Feb 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
mxpv
approved these changes
Feb 22, 2024
dcantah
approved these changes
Feb 22, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This provides go bindings for our services using go-ttrpc and shares the same types used for existing grpc services.