Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fuzzing: improve archive fuzzer #7718

Merged
merged 1 commit into from
Dec 12, 2022
Merged

fuzzing: improve archive fuzzer #7718

merged 1 commit into from
Dec 12, 2022

Conversation

AdamKorcz
Copy link
Contributor

Currently the fuzzer does not check all the files in the tar archive which it should. This pr fixes that.

Signed-off-by: AdamKorcz adam@adalogics.com

@AdamKorcz AdamKorcz marked this pull request as ready for review November 24, 2022 18:48
@k8s-ci-robot
Copy link

Hi @AdamKorcz. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

samuelkarp
samuelkarp approved these changes Nov 25, 2022
View reviewed changes
contrib/fuzz/archive_fuzzer.go Outdated Show resolved Hide resolved
dcantah
dcantah approved these changes Nov 28, 2022
View reviewed changes
Copy link
Member

@dcantah dcantah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, minor nit

@dmcgowan dmcgowan self-assigned this Nov 30, 2022
@samuelkarp
Copy link
Member

Code LGTM, but do you mind squashing the three commits into one?

@AdamKorcz
fuzzing: improve archive fuzzer
7481378 
Signed-off-by: AdamKorcz <adam@adalogics.com>
@AdamKorcz
Copy link
Contributor Author

Code LGTM, but do you mind squashing the three commits into one?

Done!

kzys
kzys approved these changes Dec 7, 2022
View reviewed changes
Copy link
Member

@kzys kzys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dmcgowan do you want to take a look?

@dmcgowan dmcgowan merged commit 1823757 into containerd:main Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kzys kzys kzys approved these changes

@dmcgowan dmcgowan dmcgowan approved these changes

@samuelkarp samuelkarp samuelkarp approved these changes

@dcantah dcantah dcantah approved these changes

Assignees

@dmcgowan dmcgowan

Labels
needs-ok-to-test
Projects
Pull Request Review
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@AdamKorcz @k8s-ci-robot @samuelkarp @kzys @dmcgowan @dcantah