Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix sdNotify func when debug level #7798

Merged
merged 1 commit into from
Dec 12, 2022
Merged

Conversation

calvin0327
Copy link
Contributor

When I was debugging locally with flag --log-level=debug, I saw the following log message:

image

so, if the err is nil, we should not to print the message.

@k8s-ci-robot
Copy link

Hi @calvin0327. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@fuweid
Copy link
Member

fuweid commented Dec 11, 2022

would you use real name in the signoff ? Thanks

Signed-off-by: wen chen <wen.chen@daocloud.io>
@calvin0327
Copy link
Contributor Author

calvin0327 commented Dec 12, 2022

would you use real name in the signoff ? Thanks

that's sure. updated

@fuweid fuweid merged commit 5e51347 into containerd:main Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants