Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump k8s.io deps to v0.26.0 #7803

Closed
wants to merge 1 commit into from
Closed

Conversation

lucacome
Copy link
Contributor

Updates k8s.io dependencies from v0.25.4 to v0.26.0.

It also updates ROOTDIR in the Makefile to remove the trailing / that was causing some commands (like make verify-vendor) to fail, at least on Mac

@k8s-ci-robot
Copy link

Hi @lucacome. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@estesp
Copy link
Member

estesp commented Dec 13, 2022

Looks like the updated k8s sets implementation now uses Go generics; our use of string sets is now deprecated, so the linter is failing:

Check failure on line 93 in pkg/cri/server/bandwidth/linux.go

@lucacome lucacome force-pushed the bump-k8s-deps branch 2 times, most recently from 84b132b to 2330e9b Compare December 14, 2022 07:20
Signed-off-by: Luca Comellini <luca.com@gmail.com>
@dcantah
Copy link
Member

dcantah commented Dec 14, 2022

Do we want to draft here until we figure out the Go version situation/review #7813?

@mikebrow
Copy link
Member

/ok-to-test

@mikebrow mikebrow added this to the 1.7 milestone Dec 14, 2022
@thaJeztah
Copy link
Member

Looks like the breaking change was introduced in kubernetes/kubernetes#112258. Reading that PRs description, that was not a real "requirement", other than making the code slightly more self-descriptive; I wonder if it should be (temporarily) reverted until go1.18 is no longer widely used.

/cc @liggitt

@k8s-ci-robot
Copy link

@thaJeztah: GitHub didn't allow me to request PR reviews from the following users: liggitt.

Note that only containerd members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

Looks like the breaking change was introduced in kubernetes/kubernetes#112258. Reading that PRs description, that was not a real "requirement", other than making the code slightly more self-descriptive; I wonder if it should be (temporarily) reverted until go1.18 is no longer widely used.

/cc @liggitt

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@liggitt
Copy link
Contributor

liggitt commented Dec 19, 2022

I wonder if it should be (temporarily) reverted until go1.18 is no longer widely used.

go1.18 goes out of support in ~Feb 2023 with the release of go1.20, so use of go 1.19 is reasonable to require in 1.26

@lucacome
Copy link
Contributor Author

Superseded by #8131

@lucacome lucacome closed this Feb 21, 2023
@lucacome lucacome deleted the bump-k8s-deps branch February 21, 2023 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants