-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump k8s.io deps to v0.26.0 #7803
Conversation
Hi @lucacome. Thanks for your PR. I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Looks like the updated k8s sets implementation now uses Go generics; our use of string sets is now deprecated, so the linter is failing:
|
84b132b
to
2330e9b
Compare
Signed-off-by: Luca Comellini <luca.com@gmail.com>
2330e9b
to
16dd226
Compare
Do we want to draft here until we figure out the Go version situation/review #7813? |
/ok-to-test |
Looks like the breaking change was introduced in kubernetes/kubernetes#112258. Reading that PRs description, that was not a real "requirement", other than making the code slightly more self-descriptive; I wonder if it should be (temporarily) reverted until go1.18 is no longer widely used. /cc @liggitt |
@thaJeztah: GitHub didn't allow me to request PR reviews from the following users: liggitt. Note that only containerd members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
go1.18 goes out of support in ~Feb 2023 with the release of go1.20, so use of go 1.19 is reasonable to require in 1.26 |
Superseded by #8131 |
Updates k8s.io dependencies from
v0.25.4
tov0.26.0
.It also updates
ROOTDIR
in the Makefile to remove the trailing/
that was causing some commands (likemake verify-vendor
) to fail, at least on Mac