Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup protobuild config #8278

Merged
merged 1 commit into from
Mar 28, 2023
Merged

Cleanup protobuild config #8278

merged 1 commit into from
Mar 28, 2023

Conversation

Iceber
Copy link
Member

@Iceber Iceber commented Mar 16, 2023

  • github.com/containerd/containerd/runtime/v1/shim/v1 has been removed

  • The api's overrides configuration only needs to be in the api/Protobuild.toml file

@k8s-ci-robot
Copy link

Hi @Iceber. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@AkihiroSuda
Copy link
Member

/ok-to-test

@Iceber
Copy link
Member Author

Iceber commented Mar 16, 2023

/retest

dcantah
dcantah approved these changes Mar 16, 2023
View reviewed changes
Copy link
Member

@dcantah dcantah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks

@fuweid
Copy link
Member

fuweid commented Mar 22, 2023

@Iceber please rebase it thanks

@Iceber
Cleanup protobuild config
0bbca7f 
Signed-off-by: Iceber Gu <wei.cai-nat@daocloud.io>
@Iceber
Copy link
Member Author

Iceber commented Mar 22, 2023

rebased

@fuweid
Copy link
Member

fuweid commented Mar 22, 2023

/retest

@estesp
Copy link
Member

estesp commented Mar 22, 2023

/test pull-containerd-node-e2e

1 similar comment
@Iceber
Copy link
Member Author

Iceber commented Mar 27, 2023

/test pull-containerd-node-e2e

@dmcgowan
Copy link
Member

/retest

@estesp
Copy link
Member

estesp commented Mar 28, 2023

/test pull-containerd-node-e2e

mikebrow
mikebrow approved these changes Mar 28, 2023
View reviewed changes
Copy link
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

fuweid
fuweid approved these changes Mar 28, 2023
View reviewed changes
Copy link
Member

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fuweid fuweid merged commit 831b9a9 into containerd:main Mar 28, 2023
@dmcgowan dmcgowan mentioned this pull request May 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AkihiroSuda AkihiroSuda AkihiroSuda approved these changes

@mikebrow mikebrow mikebrow approved these changes

@fuweid fuweid fuweid approved these changes

@dcantah dcantah dcantah approved these changes

Assignees
No one assigned
Labels
kind/cleanup ok-to-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@Iceber @k8s-ci-robot @AkihiroSuda @fuweid @estesp @dmcgowan @mikebrow @dcantah