Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/1.7] fix the task setting the runtime path #8453

Merged
merged 3 commits into from Apr 30, 2023
Merged

[release/1.7] fix the task setting the runtime path #8453

merged 3 commits into from Apr 30, 2023

Conversation

Iceber
Copy link
Member

@Iceber Iceber commented Apr 27, 2023

cherry-pick: #8208

Added a new commit c0e1286 that skips TestContainerStartWithAbsRuntimePath if the runtime is v1

@Iceber
WithRuntimePath uses the TaskInfo.RuntimePath field
d2d9eed 
Signed-off-by: Iceber Gu <wei.cai-nat@daocloud.io>
(cherry picked from commit 97064b0)
Signed-off-by: Iceber Gu <wei.cai-nat@daocloud.io>
@Iceber
integration: add container start test using abs runtime path
aa3c63c 
Signed-off-by: Iceber Gu <wei.cai-nat@daocloud.io>
(cherry picked from commit c89438e)
@Iceber
skip TestContainerStartWithAbsRuntimePath if the runtime is v1
c0e1286 
Signed-off-by: Iceber Gu <wei.cai-nat@daocloud.io>
@dmcgowan dmcgowan merged commit df64830 into containerd:release/1.7 Apr 30, 2023
49 checks passed
@kiashok kiashok mentioned this pull request May 5, 2023
Closed
@dmcgowan dmcgowan mentioned this pull request May 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmcgowan dmcgowan dmcgowan approved these changes

@AkihiroSuda AkihiroSuda AkihiroSuda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Iceber @dmcgowan @AkihiroSuda