Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/1.7] notify readiness when registered plugins are ready #8584

Merged
merged 1 commit into from May 31, 2023

Conversation

henry118
Copy link
Member

@henry118 henry118 commented May 27, 2023

cherry-pick: #8576
(cherry picked from commit 4bfcac8)

@k8s-ci-robot
Copy link

Hi @henry118. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Signed-off-by: Henry Wang <henwang@amazon.com>
(cherry picked from commit 4bfcac8)
Copy link
Member

@dcantah dcantah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if CI's happy

@estesp estesp merged commit 1418cbb into containerd:release/1.7 May 31, 2023
47 checks passed
@fuweid
Copy link
Member

fuweid commented Jun 1, 2023

I added impact/changelog tag because the behaviour has been changed. If CRI fails to restart(fail to recover existing task), the containerd is not ready. But containerd allows CRI plugin to be not-ready. We should add note to the release.

cc @dmcgowan @mikebrow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

None yet

6 participants