Publish sandbox events #8602
Merged
Publish sandbox events #8602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping CI for Draft Pull Request. |
Signed-off-by: Maksym Pavlenko <pavlenko.maksym@gmail.com>
Signed-off-by: Maksym Pavlenko <pavlenko.maksym@gmail.com>
Signed-off-by: Maksym Pavlenko <pavlenko.maksym@gmail.com>
dmcgowan
reviewed
May 30, 2023
dmcgowan
reviewed
May 30, 2023
| // Send CONTAINER_DELETED event with ContainerId equal to SandboxId. | ||
| c.cri.GenerateAndSendContainerEvent(ctx, sandboxID, sandboxID, runtime.ContainerEventType_CONTAINER_DELETED_EVENT) | ||
|
|
||
| c.sandboxStore.Delete(sandboxID) |
There was a problem hiding this comment.
Where is this delete done now?
There was a problem hiding this comment.
CRI layer is more appropriate place to remove a sandbox from the sandbox store (so it works for all implementations).
We already handle this here:
containerd/pkg/cri/sbserver/sandbox_remove.go
Line 102 in c7b9a95
Signed-off-by: Maksym Pavlenko <pavlenko.maksym@gmail.com>
Signed-off-by: Maksym Pavlenko <pavlenko.maksym@gmail.com>
dmcgowan
approved these changes
May 30, 2023
estesp
approved these changes
May 31, 2023
mxpv
added
the
cherry-pick/1.7.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
podsandbox/package, so sbserver should be less aware about pod sandbox containers./cc: @egernst