Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Docker Hub authentication example #8614

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

laupow
Copy link

@laupow laupow commented May 31, 2023

Document how to configure containerd to authenticate to a Docker Hub registry.

Resolves #8612

@k8s-ci-robot
Copy link

Hi @laupow. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@laupow laupow force-pushed the issue-8612/docker-hub-example branch 3 times, most recently from 961abee to 534b7f4 Compare May 31, 2023 20:38
docs/cri/registry.md Outdated Show resolved Hide resolved
@containerd containerd deleted a comment from israfilalam22 Jun 11, 2023
@containerd containerd deleted a comment from israfilalam22 Jun 11, 2023
@laupow laupow force-pushed the issue-8612/docker-hub-example branch from 534b7f4 to 2a5359e Compare June 15, 2023 11:02
Copy link
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for your example, see comment.. can you normalize the formatting with the other example pls :-)

docs/cri/registry.md Outdated Show resolved Hide resolved
@mikebrow
Copy link
Member

you might need to rebase to pick up the latest ci/cd fixes.. cheers

@laupow laupow force-pushed the issue-8612/docker-hub-example branch 3 times, most recently from d45104f to edb86f6 Compare July 20, 2023 10:54
@laupow laupow requested review from mikebrow and dmcgowan July 20, 2023 11:33
Copy link
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
noting that this example is also deprecated until a suitable replacement design is provided, see enclosing section..

Signed-off-by: Matt Lauer <matt.lauer@particle.io>
@laupow laupow force-pushed the issue-8612/docker-hub-example branch from edb86f6 to 288c869 Compare August 1, 2023 11:09
Copy link

@alexeyatbluescape alexeyatbluescape left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, but still not clear enough. We should be creating file /etc/containerd/certs.d/docker.io/hosts.toml, without that file this does not work (at least in EKS 1.26)

reference: #8612

I would suggest adding

mkdir -p /etc/containerd/certs.d/docker.io
cat << EOF > /etc/containerd/certs.d/docker.io/hosts.toml
server = "https://docker.io"

[host."https://registry-1.docker.io"]
  capabilities = ["pull", "resolve"]
EOF

this command somewhere in the readme.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Auth to Docker Hub registry not working
5 participants