-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Docker Hub authentication example #8614
base: main
Are you sure you want to change the base?
Conversation
Hi @laupow. Thanks for your PR. I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
961abee
to
534b7f4
Compare
534b7f4
to
2a5359e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for your example, see comment.. can you normalize the formatting with the other example pls :-)
you might need to rebase to pick up the latest ci/cd fixes.. cheers |
d45104f
to
edb86f6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
noting that this example is also deprecated until a suitable replacement design is provided, see enclosing section..
Signed-off-by: Matt Lauer <matt.lauer@particle.io>
edb86f6
to
288c869
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great, but still not clear enough. We should be creating file /etc/containerd/certs.d/docker.io/hosts.toml
, without that file this does not work (at least in EKS 1.26)
reference: #8612
I would suggest adding
mkdir -p /etc/containerd/certs.d/docker.io
cat << EOF > /etc/containerd/certs.d/docker.io/hosts.toml
server = "https://docker.io"
[host."https://registry-1.docker.io"]
capabilities = ["pull", "resolve"]
EOF
this command somewhere in the readme.
Document how to configure
containerd
to authenticate to a Docker Hub registry.Resolves #8612