Add support for image expiration during garbage collection #9022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make it easier to see list differences in gc node test failure output. Signed-off-by: Derek McGowan <derek@mcg.dev>
|
cc @cardyok |
fuweid
reviewed
Aug 30, 2023
| } | ||
|
|
||
| // If image doesn't have expiration, it does not need to be leased | ||
| if _, ok := labels[string(labelGCExpire)]; !ok { |
There was a problem hiding this comment.
Suggest to add integration test case for this. I think it will be a good example for developer.
There was a problem hiding this comment.
Let me look into adding a test under images for this, we don't usually unit test the non exported functions. I did find another fix for one of the tests though
dmcgowan
force-pushed
the
gc-image-collectible
branch
2 times, most recently
from
51a4b17
to
0949935
Compare
henry118
reviewed
Aug 31, 2023
|
One generic question: would the gc of an expired image consequently lead to GC of related resources like contents and snapshots? |
Update the garbage collector to support image expiration along with support for image leasing. This allows making images collectible during garbage collection and using a lease to prevent removal of an image. Signed-off-by: Derek McGowan <derek@mcg.dev>
Signed-off-by: Derek McGowan <derek@mcg.dev>
dmcgowan
force-pushed
the
gc-image-collectible
branch
from
0949935
to
cd705af
Compare
Yes, gc of an expired image is the equivalent of an image delete + gc |
henry118
approved these changes
Aug 31, 2023
estesp
approved these changes
Sep 12, 2023
8 tasks
dmcgowan
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the garbage collector to support image expiration along with support for image leasing. This allows making images collectible during garbage collection and using a lease to prevent removal of an image.
The
containerd.io/gc.ref.imagelabel will also allow other other objects to reference an image directly, rather than just the content. This is useful to keep around image metadata and labels rather than just the image manifest.