Move client to subpackage #9316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Derek McGowan <derek@mcg.dev>
|
Skipping CI for Draft Pull Request. |
Signed-off-by: Derek McGowan <derek@mcg.dev>
dmcgowan
force-pushed
the
rename-client-package
branch
from
ec3e8ae
to
261e01c
Compare
Signed-off-by: Derek McGowan <derek@mcg.dev>
AkihiroSuda
approved these changes
Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following pattern in CONTRIBUTING.md
While the package is renamed, the import statements set it to containerd to keep the code change smaller. We could update this in the future if we want, not necessary now though.