pkg/dialer: minor fix on dialer function for windows #9412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @profnandaa. Thanks for your PR. I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
profnandaa
force-pushed
the
fix/dialer_function_windows
branch
from
6aa5dd5
to
f2d00f1
Compare
gabriel-samfira
suggested changes
Nov 22, 2023
This commit fixes the dialer function to make sure that "npipe://" prefix is trimmed, just like the way it is done in the Unix counterpart, `./dialer_unix.go:50` This will also unblock some downstream work going on in buildkit; setting up integration tests to run on Windows. Signed-off-by: Anthony Nandaa <profnandaa@gmail.com>
profnandaa
force-pushed
the
fix/dialer_function_windows
branch
from
f2d00f1
to
8e91edb
Compare
gabriel-samfira
approved these changes
Nov 22, 2023
dmcgowan
approved these changes
Nov 22, 2023
profnandaa
changed the title
dcantah
approved these changes
Nov 22, 2023
samuelkarp
approved these changes
Nov 23, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
thanks for the prompt approvals! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes the dialer function to make sure that "npipe://" prefix is trimmed, just like the way it is done in the Unix counterpart,
./dialer_unix.go:50This will also unblock some downstream work going on in buildkit; setting up integration tests to run on Windows - moby/buildkit#4432
/cc. @gabriel-samfira