[release/1.7] Don't block snapshot garbage collection on Remove failures #9482
Conversation
|
Hi @ambarve. Thanks for your PR. I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
dmcgowan
changed the title
|
@ambarve The project check doesn't like something and it isn't clear what. I see the commit parent is a really old commit, can you try rebasing on release/1.7 HEAD and see if that fixes it? |
If a snapshot removal fails (during garbage collection), the entire garbage collection operation is cancelled. This is problematic because once cleanup of any snapshot fails no other snapshots will be cleaned and the disk usage will just keep increasing. Solution is to return snapshot removal errors wrapped as "ErrFailedPrecondition" errors. The garbage collectors continues cleanup if the error is of this type. Signed-off-by: Amit Barve <ambarve@microsoft.com> (cherry picked from commit ad96fde) Signed-off-by: Amit Barve <ambarve@microsoft.com>
ambarve
force-pushed
the
sn_cleanup_1.7
branch
from
a192e1a
to
ed7c689
Compare
If a snapshot removal fails (during garbage collection), the entire garbage collection operation is cancelled. This is problematic because once cleanup of any snapshot fails no other snapshots will be cleaned and the disk usage will just keep increasing.
Solution is to return snapshot removal errors wrapped as "ErrFailedPrecondition" errors. The garbage collectors continues cleanup if the error is of this type.
(cherry picked from commit ad96fde)