Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/1.7] *: enable ARM64 runner #9502

Merged
merged 1 commit into from Dec 15, 2023
Merged

[release/1.7] *: enable ARM64 runner #9502

merged 1 commit into from Dec 15, 2023

Conversation

akhilerm
Copy link
Member

There are many Kubernetes clusters running on ARM64. Enable ARM64 runner is to commit to support ARM64 platform officially.

(cherry picked from commit cb5a48e)

not a clean cherry-pick of #9456

estesp
estesp reviewed Dec 12, 2023
View reviewed changes
.github/workflows/ci.yml Outdated
@@ -31,7 +31,7 @@ jobs:

strategy:
matrix:
os: [ubuntu-20.04, macos-12, windows-2019]
os: [ubuntu-22.04, actuated-arm64-4cpu-16gb, macos-12, windows-2019]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure we want to upgrade the base Ubuntu version for the existing release?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Will keep it as ubuntu 20 itself.

@estesp
Copy link
Member

estesp commented Dec 13, 2023

Looks like there is a cgroups issue during tests only for the deprecated Linux runtimes, only on the arm64 hardware; more details in the CI annotated output, but all of them end up with this core error:

cgroups: cgroup mountpoint does not exist: unknown

@akhilerm
Copy link
Member Author

Looks like there is a cgroups issue during tests only for the deprecated Linux runtimes, only on the arm64 hardware; more details in the CI annotated output, but all of them end up with this core error:

cgroups: cgroup mountpoint does not exist: unknown

Yes . It happens because the arm64 runners are on ubuntu 22, which has cgroupv2 by default (cgroupv1 is disabled) . The v1 version of runc and shim only supports cgroupv1. Was thinking about skipping those tests on arm64.

Another question that I had was, when we want to migrate release/1.7 and release/1.6 branch to ubuntu22, at that time these tests will start to fail on other runners also, not just arm64.

@fuweid @akhilerm
*: enable ARM64 runner
c631651 
There are many Kubernetes clusters running on ARM64. Enable ARM64 runner
is to commit to support ARM64 platform officially.

runc.v1 and runtime.v1 runtime tests are skipped on arm64 runners
because they doesnot support cgroupv2; arm64 nodes has only ubuntu22.04
at the moment, and ubuntu22.04 has cgroupv2 enabled and cgroupv1
disabled by default.

Signed-off-by: Wei Fu <fuweid89@gmail.com>
(cherry picked from commit cb5a48e)
Signed-off-by: Akhil Mohan <akhilerm@gmail.com>
@AkihiroSuda AkihiroSuda merged commit 8d0b1c8 into containerd:release/1.7 Dec 15, 2023
56 checks passed
@akhilerm akhilerm deleted the cherry-pick-9456-1.7 branch December 15, 2023 03:55
@akhilerm
Copy link
Member Author

/cherrypick release/1.6

@k8s-infra-cherrypick-robot
Copy link

@akhilerm: #9502 failed to apply on top of branch "release/1.6":

Applying: *: enable ARM64 runner
Using index info to reconstruct a base tree...
M	.github/workflows/ci.yml
Falling back to patching base and 3-way merge...
Auto-merging .github/workflows/ci.yml
CONFLICT (content): Merge conflict in .github/workflows/ci.yml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 *: enable ARM64 runner
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick release/1.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dmcgowan dmcgowan mentioned this pull request Jan 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@estesp estesp estesp approved these changes

@AkihiroSuda AkihiroSuda AkihiroSuda approved these changes

Assignees
No one assigned
Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@akhilerm @estesp @k8s-infra-cherrypick-robot @AkihiroSuda @k8s-ci-robot @fuweid