Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable CDI by default #9621

Merged
merged 1 commit into from Jan 17, 2024
Merged

Enable CDI by default #9621

merged 1 commit into from Jan 17, 2024

Conversation

bart0sh
Copy link
Contributor

@bart0sh bart0sh commented Jan 9, 2024

CDI support is required by the Kubernetes Device Plugin framework
The support is enabled by default in the Kubernetes 1.29.

It would be great to have it enabled by default in the Containerd.

@k8s-ci-robot
Copy link

Hi @bart0sh. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bart0sh
Copy link
Contributor Author

bart0sh commented Jan 9, 2024

/assign @mikebrow @AkihiroSuda @fuweid

mikebrow
mikebrow approved these changes Jan 10, 2024
View reviewed changes
Copy link
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mikebrow
mikebrow approved these changes Jan 11, 2024
View reviewed changes
Copy link
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bart0sh
Copy link
Contributor Author

bart0sh commented Jan 12, 2024

Rebased to fix conflict with the target branch.

@bart0sh
config: enable CDI by default
c8e8a09 
Signed-off-by: Ed Bartosh <eduard.bartosh@intel.com>
@bart0sh
Copy link
Contributor Author

bart0sh commented Jan 16, 2024

@AkihiroSuda @fuweid for a second review & possible approval.

@dmcgowan dmcgowan added this to the 2.0 milestone Jan 16, 2024
@mikebrow
Copy link
Member

/ok-to-test

@AkihiroSuda AkihiroSuda added this pull request to the merge queue Jan 17, 2024
Merged via the queue into containerd:main with commit a83449c Jan 17, 2024
46 checks passed
@bart0sh
Copy link
Contributor Author

bart0sh commented Jan 17, 2024

@AkihiroSuda @mikebrow @dmcgowan Thank you very much for the review and approval!

@henry118 henry118 mentioned this pull request Jan 18, 2024
Merged
@dmcgowan dmcgowan added impact/changelog area/cri Container Runtime Interface (CRI) labels Jan 19, 2024
@dmcgowan dmcgowan changed the title config: enable CDI by default Enable CDI by default Jan 19, 2024
@bart0sh bart0sh mentioned this pull request Jan 21, 2024
Closed
@dmcgowan dmcgowan mentioned this pull request Apr 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thaJeztah thaJeztah thaJeztah left review comments

@mikebrow mikebrow mikebrow approved these changes

@dmcgowan dmcgowan dmcgowan approved these changes

@AkihiroSuda AkihiroSuda AkihiroSuda approved these changes

Assignees

@AkihiroSuda AkihiroSuda

@mikebrow mikebrow

@fuweid fuweid

Labels
area/cri Container Runtime Interface (CRI) impact/changelog ok-to-test size/S
Projects
Pull Request Review
Status: Done
Milestone
2.0
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@bart0sh @k8s-ci-robot @mikebrow @dmcgowan @thaJeztah @AkihiroSuda @fuweid