Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move plugin/fieldpath to api/types/ #9687

Merged
merged 1 commit into from
Jan 26, 2024

Conversation

akhilerm
Copy link
Member

@akhilerm akhilerm commented Jan 24, 2024

move the plugin/fieldpath to api/types/, so that api directory is independent of rest of the containerd module.

Manually tested if its breaking compatibility with older client by :

  • building and running containerd from the PR branch which uses modified protos
  • running the sample code for redis-container from here , which uses the module from main branch that uses old protos.

@k8s-ci-robot
Copy link

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@akhilerm
Copy link
Member Author

/test all

@akhilerm
Copy link
Member Author

/cc @dmcgowan

@akhilerm akhilerm added this to the 2.0 milestone Jan 25, 2024
@akhilerm akhilerm changed the title WIP: refactor: move plugin/fieldpath to api/ refactor: move plugin/fieldpath to api/ Jan 25, 2024
@akhilerm
Copy link
Member Author

Manually tested if its breaking compatibility with older client by :

  • building and running containerd from the PR branch which uses modified protos
  • running the sample code for redis-container from here , which uses the module from main branch that uses old protos.

@akhilerm akhilerm marked this pull request as ready for review January 25, 2024 18:53
Signed-off-by: Akhil Mohan <akhilerm@gmail.com>
@akhilerm akhilerm changed the title refactor: move plugin/fieldpath to api/ refactor: move plugin/fieldpath to api/types/ Jan 25, 2024
@estesp estesp added this pull request to the merge queue Jan 26, 2024
Merged via the queue into containerd:main with commit 3d93add Jan 26, 2024
46 checks passed
@akhilerm akhilerm deleted the refactor-protos branch January 28, 2024 05:03
@akhilerm akhilerm restored the refactor-protos branch February 19, 2024 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

None yet

5 participants