New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add OSVersion to platform protobuf #9733
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kiashok
force-pushed
the
platform-protobuf
branch
from
February 1, 2024 23:14
736fbcf
to
bd17514
Compare
jsturtevant
reviewed
Feb 1, 2024
kiashok
force-pushed
the
platform-protobuf
branch
from
February 7, 2024 18:08
bd17514
to
f8340f1
Compare
kiashok
force-pushed
the
platform-protobuf
branch
from
February 7, 2024 18:11
f8340f1
to
c0d5b00
Compare
cpuguy83
reviewed
Feb 7, 2024
Signed-off-by: kiashok <kiashok@microsoft.com>
kiashok
force-pushed
the
platform-protobuf
branch
from
February 7, 2024 19:31
c0d5b00
to
f4b9395
Compare
It also extends the functions in api/types/platform_helpers.go Signed-off-by: kiashok <kiashok@microsoft.com>
kiashok
force-pushed
the
platform-protobuf
branch
from
February 7, 2024 19:33
f4b9395
to
5aa0548
Compare
LGTM |
MikeZappa87
approved these changes
Feb 7, 2024
cpuguy83
reviewed
Feb 7, 2024
cpuguy83
approved these changes
Feb 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
dmcgowan
approved these changes
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add OSVersion to platform protobuf and extend the functions in api/types/platform_helpers.go