-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build with Go 1.22.0 #9794
Build with Go 1.22.0 #9794
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
k8s is moving, so cri-api will need 1.22.0 when k8s 1.30 is shipped middle of April. We would be ahead of the curve in adoption for sure. Since this is 2.0 branch/work, i'd love for us to go for it!
go-winio may need a fix for go1.22; see |
We're preparing 2.0 release and I think we should use go1.21 because it's stable. Go1.22 should be applied after 2.0 release if there is no required feature using go1.22. |
@fuweid @kiashok we had discussed this earlier, staying on 1.21 for the 2.0 release but replacing building 1.20 with 1.22 in the build matrix. Agreed we should not move up a go release yet, but we can remove 1.20 support and make sure we are building against 1.22. This is typically the state release branches end up anyway, test and release with n-1 go version but ensure builds with latest. |
Oh okay sorry, I think I misunderstood it. Will work on this right now and push new changes |
aeb0027
to
06a8ab5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM on green
Signed-off-by: Kirtana Ashok <kiashok@microsoft.com>
06a8ab5
to
87aa9e8
Compare
Apparently Go 1.22 has a regression (affects runc) |
We saw other issues with CGO as well (broken on some 32-bit arm versions) |
This isn't a blocker for this PR since we are only doing a build check against 1.22 and not switching the test/release pipelines before 2.0. |
Drop go 1.20 and build with 1.22 .