Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build with Go 1.22.0 #9794

Merged
merged 1 commit into from
Feb 9, 2024
Merged

Build with Go 1.22.0 #9794

merged 1 commit into from
Feb 9, 2024

Conversation

kiashok
Copy link
Contributor

@kiashok kiashok commented Feb 8, 2024

Drop go 1.20 and build with 1.22 .

Copy link
Member

@dims dims left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

k8s is moving, so cri-api will need 1.22.0 when k8s 1.30 is shipped middle of April. We would be ahead of the curve in adoption for sure. Since this is 2.0 branch/work, i'd love for us to go for it!

@thaJeztah
Copy link
Member

@fuweid
Copy link
Member

fuweid commented Feb 8, 2024

We're preparing 2.0 release and I think we should use go1.21 because it's stable. Go1.22 should be applied after 2.0 release if there is no required feature using go1.22.

@dmcgowan
Copy link
Member

dmcgowan commented Feb 8, 2024

@fuweid @kiashok we had discussed this earlier, staying on 1.21 for the 2.0 release but replacing building 1.20 with 1.22 in the build matrix. Agreed we should not move up a go release yet, but we can remove 1.20 support and make sure we are building against 1.22. This is typically the state release branches end up anyway, test and release with n-1 go version but ensure builds with latest.

@kiashok
Copy link
Contributor Author

kiashok commented Feb 9, 2024

@fuweid @kiashok we had discussed this earlier, staying on 1.21 for the 2.0 release but replacing building 1.20 with 1.22 in the build matrix. Agreed we should not move up a go release yet, but we can remove 1.20 support and make sure we are building against 1.22. This is typically the state release branches end up anyway, test and release with n-1 go version but ensure builds with latest.

Oh okay sorry, I think I misunderstood it. Will work on this right now and push new changes

@kiashok kiashok changed the title Go 1.22.0 Build with Go 1.22.0 Feb 9, 2024
Copy link
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dmcgowan dmcgowan requested a review from fuweid February 9, 2024 01:42
Copy link
Member

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on green

Signed-off-by: Kirtana Ashok <kiashok@microsoft.com>
@AkihiroSuda
Copy link
Member

Apparently Go 1.22 has a regression (affects runc)

@thaJeztah
Copy link
Member

We saw other issues with CGO as well (broken on some 32-bit arm versions)

@kiashok
Copy link
Contributor Author

kiashok commented Feb 9, 2024

LGTM on green

tests are passing now @fuweid @dmcgowan @mikebrow

@dmcgowan
Copy link
Member

dmcgowan commented Feb 9, 2024

We saw other issues with CGO as well (broken on some 32-bit arm versions)

This isn't a blocker for this PR since we are only doing a build check against 1.22 and not switching the test/release pipelines before 2.0.

@dmcgowan dmcgowan added this pull request to the merge queue Feb 9, 2024
Merged via the queue into containerd:main with commit 528dcfa Feb 9, 2024
46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants