-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(docs): fix duplicate instructions for windows installation #9894
fix(docs): fix duplicate instructions for windows installation #9894
Conversation
Hi @profnandaa. Thanks for your PR. I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This commit fixes the duplicate copy and configure steps for the Windows powershell scripts. fixes containerd#9887 It also adds the architecture as a variable in preparation for the ARM64 support that is coming. Signed-off-by: Anthony Nandaa <profnandaa@gmail.com>
335d5fd
to
c5ef8a2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR keeps being removed from the merge queue, anyone can help on this? |
This commit fixes the duplicate copy and configure steps for the Windows powershell scripts.
fixes #9887
It also adds the architecture as a variable in preparation for the ARM64 support that is coming.