Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): fix duplicate instructions for windows installation #9894

Merged

Conversation

profnandaa
Copy link
Contributor

This commit fixes the duplicate copy and configure steps for the Windows powershell scripts.

fixes #9887

It also adds the architecture as a variable in preparation for the ARM64 support that is coming.

@k8s-ci-robot
Copy link

Hi @profnandaa. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This commit fixes the duplicate copy and configure steps for
the Windows powershell scripts.

fixes containerd#9887

It also adds the architecture as a variable in preparation for
the ARM64 support that is coming.

Signed-off-by: Anthony Nandaa <profnandaa@gmail.com>
Copy link

@iankingori iankingori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dmcgowan dmcgowan added this pull request to the merge queue Feb 29, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 29, 2024
@estesp estesp added this pull request to the merge queue Mar 27, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 27, 2024
@mxpv mxpv added this pull request to the merge queue Mar 29, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 29, 2024
@profnandaa
Copy link
Contributor Author

PR keeps being removed from the merge queue, anyone can help on this?

@AkihiroSuda AkihiroSuda added this pull request to the merge queue Apr 23, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 23, 2024
@AkihiroSuda AkihiroSuda added this pull request to the merge queue Apr 23, 2024
Merged via the queue into containerd:main with commit 9d108fa Apr 24, 2024
45 checks passed
@profnandaa profnandaa deleted the docs/fix-windows-instructions-2 branch April 24, 2024 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Powershell script on windows installation
7 participants