Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/1.7] Handle pod transition states gracefully while listing pod stats #9905

Merged
merged 2 commits into from Mar 1, 2024
Merged

[release/1.7] Handle pod transition states gracefully while listing pod stats #9905

merged 2 commits into from Mar 1, 2024

Conversation

dims
Copy link
Member

@dims dims commented Mar 1, 2024 •
edited

original PR text from #8671

When the pods are transitioning there are several cases where containers might not be in valid state. There were several 
cases where the stats where failing hard but we should just continue on as they are transient  and will be picked up again 
when kubelet queries for the stats again.

I've found these after running the e2e tests in https://github.com/kubernetes/kubernetes/pull/116968 several times.

@jsturtevant @dims
[cri] Handle Windows pod transitions gracefully
579d8b4 
When the pods are transitioning there are several
cases where containers might not be in valid state.
There were several cases where the stats where
failing hard but we should just continue on as
they are transient and will be picked up again
when kubelet queries for the stats again.

Signed-off-by: James Sturtevant <jstur@microsoft.com>

Signed-off-by: Mark Rossetti <marosset@microsoft.com>
@dims dims assigned dims, fuweid and AkihiroSuda and unassigned dims Mar 1, 2024
fuweid
fuweid approved these changes Mar 1, 2024
View reviewed changes
Copy link
Member

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dims
adjust test cases to run for windows
39db3f1 
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
@estesp estesp merged commit 80a8047 into containerd:release/1.7 Mar 1, 2024
56 checks passed
@dims dims mentioned this pull request Mar 2, 2024
Closed
@dmcgowan dmcgowan added area/cri Container Runtime Interface (CRI) impact/changelog labels Mar 7, 2024
@dmcgowan dmcgowan changed the title [release/1.7][cri] Handle pod transition states gracefully while listing pod stats [release/1.7] Handle pod transition states gracefully while listing pod stats Mar 8, 2024
@dmcgowan dmcgowan mentioned this pull request Mar 8, 2024
Merged
This was referenced Mar 14, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@estesp estesp estesp approved these changes

@fuweid fuweid fuweid approved these changes

Assignees

@AkihiroSuda AkihiroSuda

@fuweid fuweid

Labels
area/cri Container Runtime Interface (CRI) impact/changelog size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@dims @estesp @fuweid @dmcgowan @AkihiroSuda @k8s-ci-robot @jsturtevant