New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/1.6] Update builds to go 1.21.8 #9945
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
@@ -12,7 +12,7 @@ on: | |||
env: | |||
# Go version we currently use to build containerd across all CI. | |||
# Note: don't forget to update `Binaries` step, as it contains the matrix of all supported Go versions. | |||
GO_VERSION: "1.20.13" | |||
GO_VERSION: "1.21.8" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we missed one change in #9890. Because after setting up composite action, we should not be setting GO_VERSION
env in the workflow file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Included the missing change in the action now, but this file doesn't seem to be updated to use the action
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have pushed the changes here dmcgowan#3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have added one more commit to fix the linter issues
See https://groups.google.com/g/golang-announce/c/5pwGVUPoMbg Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
Looks like the changes to use the composite action were dropped again in the push. |
@austinvazquez I removed it, CI was failing. We can update that in a follow up. |
Similar to:
Carry #9934