Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix typo #9998

Merged
merged 1 commit into from
Mar 26, 2024
Merged

docs: fix typo #9998

merged 1 commit into from
Mar 26, 2024

Conversation

irLinja
Copy link
Contributor

@irLinja irLinja commented Mar 26, 2024

fixed a small typo in the docs

@k8s-ci-robot
Copy link

Hi @irLinja. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@estesp
Copy link
Member

estesp commented Mar 26, 2024

Thanks for the typo fixes; can you add a Signed-off-by: line to your commit to pass our CI checks? More details here: https://github.com/containerd/project/blob/main/CONTRIBUTING.md#sign-your-work

Signed-off-by: Arash Haghighat <arash@linja.pro>
@irLinja
Copy link
Contributor Author

irLinja commented Mar 26, 2024

@estesp I should add that to my workflow. Thanks for pointing it out.

@estesp estesp added this pull request to the merge queue Mar 26, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 26, 2024
@estesp estesp added this pull request to the merge queue Mar 26, 2024
Merged via the queue into containerd:main with commit 9c99229 Mar 26, 2024
45 checks passed
@irLinja irLinja deleted the typo branch March 26, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants