sysx/xattr: fix and improve #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current implementation is suboptimal for two reasons: * the initial buffer size of 5 bytes makes no sense (my guess someone forgot to change it back to a sane value after the retry logic testing); * it never gets the real buffer size, resulting in extra iterations (5 -> 10 -> 20 -> ...). This commit * sets the initial size to 128; * uses the logic to get the real size in case we get ERANGE Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
The current code * is hard to read (at least for me, that is); * is suboptimal (always calls listxattr() twice); * doesn't handle the condition when attributes size is changed in between the two calls to listxattr(). Fix all three issues by reusing the logic from getxattrAll(). Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Zyqsempai
reviewed
Feb 27, 2020
@Zyqsempai Sorry, I don't get it. Do you mean something other than the
line which is present in both commits? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. fix
getxattrAllThe current implementation is suboptimal for two reasons:
the initial buffer size of 5 bytes makes no sense
(my guess @stevvooe forgot to change it back to a sane
value after the initial retry logic testing);
it never gets the real buffer size, resulting in extra
iterations (5 -> 10 -> 20 -> ...).
This commit
128;ERANGE(rather than doubling the buffer)
2. improve
listxattrAllThe current code
listxattr()twice);is changed in between the two calls to
listxattr().Fix all three issues at once by reusing the logic from
getxattrAll().