Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: resolve Go path before sudoing ; Remove deprecated io/ioutil (except ioutil.ReadDir) #198

Merged
merged 3 commits into from Apr 2, 2022

Conversation

AkihiroSuda
Copy link
Member

@AkihiroSuda AkihiroSuda commented Mar 30, 2022

Accidentally we had been using Go 1.15 (?) when sudoing

This PR also removes the deprecated io/ioutil package (except ioutil.ReadDir) to ensure that we are using the correct version of Go.

@AkihiroSuda AkihiroSuda force-pushed the go-1.17 branch 4 times, most recently from 18df8b4 to 2b9d890 Compare March 30, 2022 10:29
@AkihiroSuda AkihiroSuda marked this pull request as ready for review March 30, 2022 10:30
@AkihiroSuda AkihiroSuda marked this pull request as draft March 30, 2022 10:34
@AkihiroSuda AkihiroSuda changed the title CI: fix Go version CI: resolve Go path before sudoing ; Remove deprecated io/ioutil (except ioutil.ReadDir) Mar 30, 2022
@AkihiroSuda AkihiroSuda force-pushed the go-1.17 branch 2 times, most recently from e523942 to 229d93a Compare March 30, 2022 11:34
@AkihiroSuda AkihiroSuda marked this pull request as ready for review March 30, 2022 11:46
Copy link
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
See actions/setup-go issue 104

Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
@dmcgowan dmcgowan added this to Ready For Review in Code Review Apr 1, 2022
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

we can probably look at replacing ioutil.ReadDir() as well (but fine for a follow up)

@AkihiroSuda AkihiroSuda merged commit d790d3d into containerd:main Apr 2, 2022
Code Review automation moved this from Ready For Review to Done Apr 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants