Add paths to windows metadataFiles #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabriel-samfira
force-pushed
the
add-paths-to-metadata-files
branch
from
e651327
to
a1433d9
Compare
dcantah
approved these changes
Feb 6, 2023
estesp
reviewed
Feb 6, 2023
When creating a new empty base layer on Windows, hcsshim creates a set of empty registry hives in C:\Windows\System32\config. These files are needed in order for the new layer to be considered valid. Add these locations to the metadataFiles, which excludes them when comparing the diffs of two layers. Signed-off-by: Gabriel Adrian Samfira <gsamfira@cloudbasesolutions.com>
gabriel-samfira
force-pushed
the
add-paths-to-metadata-files
branch
from
a1433d9
to
68f7b34
Compare
austinvazquez
approved these changes
Feb 6, 2023
kzys
approved these changes
Feb 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating a new empty base layer on Windows, hcsshim creates a set of empty registry hives in C:\Windows\System32\config. These files are needed in order for the new layer to be considered valid.
Add these locations to the metadataFiles, which excludes them when comparing the diffs of two layers.
This will be used in the snapshot tests on Windows in: containerd/containerd#8043
Signed-off-by: Gabriel Adrian Samfira gsamfira@cloudbasesolutions.com