Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

atomicWriteFile: file defer close #213

Merged
merged 1 commit into from
Mar 6, 2023
Merged

atomicWriteFile: file defer close #213

merged 1 commit into from
Mar 6, 2023

Conversation

helen-frank
Copy link
Contributor

fuweid
fuweid reviewed Feb 23, 2023
View reviewed changes
ioutils.go Outdated Show resolved Hide resolved
@helen-frank
atomicWriteFile: file defer close
9eb2a49 
Signed-off-by: helen <haitao.zhang@daocloud.io>
austinvazquez
austinvazquez approved these changes Feb 24, 2023
View reviewed changes
Copy link
Contributor

@austinvazquez austinvazquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dmcgowan dmcgowan merged commit 6f1e02f into containerd:main Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmcgowan dmcgowan dmcgowan approved these changes

@cpuguy83 cpuguy83 cpuguy83 approved these changes

@fuweid fuweid fuweid approved these changes

@austinvazquez austinvazquez austinvazquez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Pull Request Review
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@helen-frank @dmcgowan @cpuguy83 @fuweid @austinvazquez