Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update GitHub Actions runner images #216

Merged
merged 1 commit into from
Feb 27, 2023
Merged

Update GitHub Actions runner images #216

merged 1 commit into from
Feb 27, 2023

Conversation

austinvazquez
Copy link
Contributor

Resolves deprecation warnings in CI by moving macOS from 10.15 to 12.

Signed-off-by: Austin Vazquez macedonv@amazon.com

@estesp
Copy link
Member

estesp commented Feb 27, 2023

Does anyone from the Windows side have an opinion on whether it's better to test both windows-2019 and windows-2022 or OK to move to windows-2022 only? @kevpar?

@kevpar
Copy link
Member

kevpar commented Feb 27, 2023

Does anyone from the Windows side have an opinion on whether it's better to test both windows-2019 and windows-2022 or OK to move to windows-2022 only? @kevpar?

I'd recommend we keep both windows-2019 and windows-2022 for the time being. There are a lot of container users still on 2019.

@austinvazquez
Copy link
Contributor Author

Does anyone from the Windows side have an opinion on whether it's better to test both windows-2019 and windows-2022 or OK to move to windows-2022 only? @kevpar?

I'd recommend we keep both windows-2019 and windows-2022 for the time being. There are a lot of container users still on 2019.

Sounds good. Thanks @kevpar. Will revert and add the new Windows runner to the testing matrix.

@austinvazquez
Update GitHub Actions runner images
ad9c903 
Resolves deprecation warnings in CI by moving macOS from 10.15 to 12.
Adds windows-2022 to testing matrix.

Signed-off-by: Austin Vazquez <macedonv@amazon.com>
@estesp estesp merged commit d6500b3 into containerd:main Feb 27, 2023
@austinvazquez austinvazquez deleted the update-github-actions-images branch February 28, 2023 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samuelkarp samuelkarp samuelkarp approved these changes

@estesp estesp estesp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@austinvazquez @estesp @kevpar @samuelkarp