Skip to content
This repository has been archived by the owner on Mar 9, 2022. It is now read-only.

Commit

Permalink
Merge pull request #1028 from fuweid/detect-dirty-vendor
Browse files Browse the repository at this point in the history
hack/Makefile: detect dirty vendor
  • Loading branch information
Random-Liu committed Jan 25, 2019
2 parents 4dd6735 + 1192220 commit 538a361
Show file tree
Hide file tree
Showing 2 changed files with 38 additions and 4 deletions.
16 changes: 12 additions & 4 deletions Makefile
Expand Up @@ -60,7 +60,7 @@ help:
@echo " * 'version' - Print current cri plugin release version"
@echo " * 'update-vendor' - Syncs containerd/vendor.conf -> vendor.conf and sorts vendor.conf"

verify: lint gofmt boiler
verify: lint gofmt boiler check-vendor

version:
@echo $(VERSION)
Expand All @@ -77,6 +77,10 @@ boiler:
@echo "checking boilerplate"
@./hack/verify-boilerplate.sh

check-vendor:
@echo "detecting dirty vendor"
@./hack/verify-vendor.sh

.PHONY: sort-vendor sync-vendor update-vendor

sort-vendor:
Expand Down Expand Up @@ -172,9 +176,9 @@ else
git-validation -v -run DCO,short-subject -range $(EPOCH_TEST_COMMIT)..HEAD
endif

.PHONY: install.tools .install.gitvalidation .install.gometalinter
.PHONY: install.tools .install.gitvalidation .install.gometalinter .install.vndr

install.tools: .install.gitvalidation .install.gometalinter
install.tools: .install.gitvalidation .install.gometalinter .install.vndr

.install.gitvalidation:
$(GO) get -u github.com/vbatts/git-validation
Expand All @@ -183,6 +187,9 @@ install.tools: .install.gitvalidation .install.gometalinter
$(GO) get -u github.com/alecthomas/gometalinter
gometalinter --install

.install.vndr:
$(GO) get -u github.com/LK4D4/vndr

.PHONY: \
binaries \
static-binaries \
Expand All @@ -205,4 +212,5 @@ install.tools: .install.gitvalidation .install.gometalinter
test-e2e-node \
uninstall \
version \
proto
proto \
check-vendor
26 changes: 26 additions & 0 deletions hack/verify-vendor.sh
@@ -0,0 +1,26 @@
#!/usr/bin/env bash
#
# Copyright The containerd Authors.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

set -o errexit
set -o nounset
set -o pipefail

tmpdir="$(mktemp -d)"
trap "rm -rf ${tmpdir}" EXIT

git clone "https://github.com/containerd/project" "${tmpdir}"
"${tmpdir}"/script/validate/vendor
unset tmpdir

0 comments on commit 538a361

Please sign in to comment.