Skip to content
This repository has been archived by the owner on Mar 9, 2022. It is now read-only.

[WCOW] Revisit sandbox container cpu shares #1297

Closed
Random-Liu opened this issue Sep 25, 2019 · 0 comments
Closed

[WCOW] Revisit sandbox container cpu shares #1297

Random-Liu opened this issue Sep 25, 2019 · 0 comments

Comments

@Random-Liu
Copy link
Member

Ideally, the sandbox container for windows should have different CPU shares with linux because:

  1. windows sandbox container handles portforward;
  2. windows cpu shares range is 5000-10000 (see here), which is different from 2-1024 on linux (see here).

However, we still use the same CPU shares for now, because:

  1. The underlying job cpu rate control only supports 1-9 shares on windows, so it doesn't matter whether we use 2 or 20 here. (See here)
  2. It is not clear how much cpu portforward will need. We may want to have a better default configured, or even make it configurable if it causes trouble for some users who rely on portforward heavily.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants