Skip to content
This repository has been archived by the owner on Mar 9, 2022. It is now read-only.

Support Privileged. #29

Closed
Random-Liu opened this issue May 9, 2017 · 6 comments
Closed

Support Privileged. #29

Random-Liu opened this issue May 9, 2017 · 6 comments
Assignees

Comments

@Random-Liu
Copy link
Member

Privileged is initially a Docker concept. Docker grants a group of permissions and mounts a group of directories into a privileged pod.

In Kubernetes, we should define our own Privileged kubernetes/kubernetes#44503. For now, we could do whatever docker is doing.

Things to do:

  1. Figure out what docker is doing to Privileged container.
  2. Do the same in cri-contained.

/cc @heartlock

@heartlock
Copy link
Contributor

I will take this task. Wait for #22

@Random-Liu
Copy link
Member Author

@heartlock I'll update #22 today, and will try to get it merged this week.

@Random-Liu
Copy link
Member Author

FYI, @heartlock The container lifecycle PR is merged. #22

@heartlock
Copy link
Contributor

@Random-Liu ok, will do it.

@Random-Liu
Copy link
Member Author

Random-Liu commented May 24, 2017

@heartlock For the device mapping, you could reference the cri-o implementation. https://github.com/kubernetes-incubator/cri-o/blob/master/server/container_create.go#L68-L93

For CRI config -> runc config part, we are very similar. :p

@Random-Liu Random-Liu added this to the v0.1.0-rc2 milestone May 30, 2017
@Random-Liu
Copy link
Member Author

Close this one since the PR is merged.

Thanks @heartlock

abwah pushed a commit to abwah/cri that referenced this issue Aug 26, 2019
Revendor containerd and update dependencies
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants