Skip to content
This repository has been archived by the owner on Mar 9, 2022. It is now read-only.

Use golang 1.11.6 for now. #1124

Merged
merged 1 commit into from Apr 8, 2019
Merged

Use golang 1.11.6 for now. #1124

merged 1 commit into from Apr 8, 2019

Conversation

Random-Liu
Copy link
Member

1.11.7 doesn't work on travis right now:

/home/travis/.gimme/versions/go1.11.7.linux.amd64/pkg/tool/linux_amd64/link: running gcc failed: exit status 1
/usr/bin/ld: /tmp/go-link-869411160/000016.o: unrecognized relocation (0x2a) in section `.text'
/usr/bin/ld: final link failed: Bad value

See:

Signed-off-by: Lantao Liu lantaol@google.com

@Random-Liu
Use golang 1.11.6 for now.
c20ba1e 
Signed-off-by: Lantao Liu <lantaol@google.com>
mikebrow
mikebrow approved these changes Apr 8, 2019
View reviewed changes
Copy link
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@Random-Liu Random-Liu merged commit ebb0928 into containerd:master Apr 8, 2019
@Random-Liu Random-Liu deleted the use-golang-1-11-6 branch April 8, 2019 21:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mikebrow mikebrow mikebrow approved these changes

Assignees

@abhi abhi

@mikebrow mikebrow

Labels
lgtm size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Random-Liu @mikebrow @abhi @k8s-ci-robot