-
Notifications
You must be signed in to change notification settings - Fork 350
Conversation
de5a789
to
399a493
Compare
}() | ||
} | ||
|
||
func dumpStacks() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
from: https://golang.org/src/runtime/debug/stack.go, just a little cleaner with a modification to dump all (true)
func stack() []byte {
buf := make([]byte, 1024)
for {
n := runtime.Stack(buf, true)
if n < len(buf) {
return buf[:n]
}
buf = make([]byte, 2*len(buf))
}
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/LGTM either way with or without the stack() api..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
399a493
to
b4b679e
Compare
Signed-off-by: Lantao Liu <lantaol@google.com>
b4b679e
to
439ee0a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/LGTM
Using the same code with containerd/containerd#292.
Signed-off-by: Lantao Liu lantaol@google.com