This repository has been archived by the owner on Mar 9, 2022. It is now read-only.
Caching IP allocated by CNI plugin #525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Random-Liu
reviewed
Jan 5, 2018
pkg/store/sandbox/sandbox.go
Outdated
| @@ -34,6 +34,8 @@ type Sandbox struct { | |||
| Container containerd.Container | |||
| // CNI network namespace client | |||
| NetNS *NetNS | |||
| // Pod IP if it is attached to non host network | |||
There was a problem hiding this comment.
// IP is the ...
Comment should start with the variable name.
pkg/server/sandbox_status.go
Outdated
| @@ -57,7 +56,7 @@ func (c *criContainerdService) PodSandboxStatus(ctx context.Context, r *runtime. | |||
| processStatus = taskStatus.Status | |||
| } | |||
|
|
|||
| ip, err := c.getIP(sandbox) | |||
| ip := c.getIP(sandbox) | |||
| if err != nil { | |||
Random-Liu
reviewed
Jan 5, 2018
pkg/server/sandbox_run.go
Outdated
| if err != nil { | ||
| return nil, fmt.Errorf("failed to get network status for sandbox %q: %v", id, err) | ||
| } | ||
| sandbox.IP = ip |
There was a problem hiding this comment.
Please add comment to explain that some VM based solution is relying on this behavior, and link the issue. And we should try to eliminate the assumption on cri shim implementation detail in the future.
Signed-off-by: abhi <abhi@docker.com>
|
/lgtm |
|
Merging @nlacasse. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A Possible fix to address scenario mentioned in #524
Cache the IP allocated for pods not connected to host network and avoid fetch it on every Sandbox status request.
Signed-off-by: abhi abhi@docker.com