This repository has been archived by the owner on Mar 9, 2022. It is now read-only.
Serve streaming on localhost by default to match k8s 1.11 default. #858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Random-Liu
force-pushed
the
stream-serve-on-local
branch
from
b4d3c05
to
cb76641
Compare
mikebrow
approved these changes
Jul 20, 2018
Just to clarify, with this PR, we are going to use arbitrary (non-fixed) port on localhost. Because it is localhost, there shouldn't be security problem ideally. |
|
Sry was typing fast. I meant Agree with arbitrary point, but specified is more secure. Release note and maybe a note in the config.md will suffice. |
|
Which reminds me.. can we update the comment for this up on line 105- and the config.md? |
|
@mikebrow Make sense... Will do! Thanks for reminding! |
Signed-off-by: Lantao Liu <lantaol@google.com>
Random-Liu
force-pushed
the
stream-serve-on-local
branch
from
cb76641
to
b3d6f16
Compare
|
@mikebrow Done. |
Random-Liu
added a commit
that referenced
this pull request
Jul 24, 2018
Cherrypick #858 to release/1.11.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #777.
Change the default config to match Kubernetes 1.11 default behavior.
Initially, I thought we should keep default unchanged so that the default config can work with both K8s 1.10 and 1.11.
However, I talked with @dmcgowan today, and we found users don't like arbitrary fixed port listening. Given that we don't need a fixed port anymore for K8s 1.11, I think we should change the default to match the k8s 1.11 behavior to get rid of this fixed port.
We need to mention in the release note that, if you want to use containerd 1.2 with K8s 1.10, please set
stream_server_address=""andstream_server_portto a fixed port if you need a fixed one.Signed-off-by: Lantao Liu lantaol@google.com