-
Notifications
You must be signed in to change notification settings - Fork 349
Conversation
@Random-Liu: GitHub didn't allow me to request PR reviews from the following users: jingax10, cadmuxe. Note that only containerd members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
cluster/gce/configure.sh
Outdated
cni_template_path="" | ||
if [ "${KUBERNETES_MASTER:-}" != "true" ]; then | ||
if [ "${NETWORK_POLICY_PROVIDER:-"none"}" != "none" ] || [ "${ENABLE_NETD:-}" == "true" ]; then | ||
# Use Kubernetes cni daemonset on node if network policy provider is specified. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: please revise the comment to match updated logic
e.g., if network policy provider is specified or netd is enabled
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Signed-off-by: Lantao Liu <lantaol@google.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/LGTM
/lgtm |
Cherrypick #869 into release/1.11
We should cherrypick this to 1.11, because netd support is added in Kubernetes 1.11. kubernetes/kubernetes#64591
Signed-off-by: Lantao Liu lantaol@google.com