Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the type of PdeathSignal #61

Merged
merged 1 commit into from
Jun 12, 2020

Conversation

KentaTada
Copy link
Contributor

As related to containerd/containerd#4317, this commit changes the definition of PdeathSignal to use x/sys.

Signed-off-by: Kenta Tada Kenta.Tada@sony.com

Use x/sys instead of syscall

Signed-off-by: Kenta Tada <Kenta.Tada@sony.com>
@codecov-commenter
Copy link

Codecov Report

Merging #61 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #61   +/-   ##
=======================================
  Coverage   12.26%   12.26%           
=======================================
  Files           7        7           
  Lines         644      644           
=======================================
  Hits           79       79           
  Misses        543      543           
  Partials       22       22           
Impacted Files Coverage Δ
runc.go 7.04% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7016d3c...421b4ca. Read the comment docs.

Copy link
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crosbymichael
Copy link
Member

LGTM

@crosbymichael crosbymichael merged commit 0d18714 into containerd:master Jun 12, 2020
@thehajime
Copy link
Contributor

I filed an issue (#65): please take a look at it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants