Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go.mod: github.com/containerd/containerd v2.0.0-rc.3 #158

Merged
merged 1 commit into from
Jun 22, 2024

Conversation

thaJeztah
Copy link
Member

@thaJeztah thaJeztah commented Jun 21, 2024

rc.3 rmoves pkg/seed, so removing that import from cmd/ctr

full diff: containerd/containerd@v2.0.0-rc.2...v2.0.0-rc.3

rc.3 rmoves pkg/seed, so removing that import from cmd/ctr

full diff: containerd/containerd@v2.0.0-rc.2...v2.0.0-rc.3

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Copy link
Contributor

@stefanberger stefanberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AkihiroSuda AkihiroSuda merged commit 6b4ba3f into containerd:main Jun 22, 2024
8 checks passed
@thaJeztah thaJeztah deleted the bump_containerd_rc3 branch June 22, 2024 07:28
@AkihiroSuda
Copy link
Member

@stefanberger @lumjjb Can we make a new release?

@stefanberger
Copy link
Contributor

@stefanberger @lumjjb Can we make a new release?

Why not wait until v2.0.0 has been released?

@AkihiroSuda
Copy link
Member

Because containerd v2 vendors a "random main commit" of imgcrypt.
The new release of imgcrypt should be like v2.0.0-rc.0 perhaps

@thaJeztah
Copy link
Member Author

The new release of imgcrypt should be like v2.0.0-rc.0 perhaps

Does it need a major version update? 😬 (if that's the case, there's probably a lot more to do; updating import paths everywhere)

@AkihiroSuda
Copy link
Member

Can be also v1.2.0-rc.0

@stefanberger
Copy link
Contributor

I tagged v1.2.0-rc1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants