images: prepare for typeurl.Any #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typeurl.MarshalAny returns typeurl.Any since containerd/typeurl#32. Signed-off-by: Kazuyoshi Kato <katokazu@amazon.com>
|
It passes the tests so it doesn't seem to have any side effects... |
Yes. fromAny() is essentially no-op since this package is only passing *types.Any. This will help changes like containerd/containerd#6706. |
kzys
added a commit
to kzys/containerd
that referenced
this pull request
Mar 22, 2022
…image-spec - Upgrade github.com/containerd/imgcrypt to prepare for typeurl upgrade (see containerd/imgcrypt#72) - Upgrade github.com/opencontainers/image-spec since imgcrypto needs at least 1.0.2. Signed-off-by: Kazuyoshi Kato <katokazu@amazon.com>
kzys
added a commit
to kzys/containerd
that referenced
this pull request
Mar 22, 2022
- Upgrade github.com/containerd/imgcrypt to prepare for typeurl upgrade (see containerd/imgcrypt#72) - Upgrade github.com/opencontainers/image-spec since imgcrypto needs at least 1.0.2. Signed-off-by: Kazuyoshi Kato <katokazu@amazon.com>
kzys
added a commit
to kzys/containerd
that referenced
this pull request
Mar 22, 2022
- Upgrade github.com/containerd/imgcrypt to prepare for typeurl upgrade (see containerd/imgcrypt#72) - Upgrade github.com/opencontainers/image-spec since imgcrypto needs at least 1.0.2. Signed-off-by: Kazuyoshi Kato <katokazu@amazon.com>
dims
pushed a commit
to dims/containerd-api-only
that referenced
this pull request
Mar 26, 2022
- Upgrade github.com/containerd/imgcrypt to prepare for typeurl upgrade (see containerd/imgcrypt#72) - Upgrade github.com/opencontainers/image-spec since imgcrypto needs at least 1.0.2. Signed-off-by: Kazuyoshi Kato <katokazu@amazon.com>
dims
pushed a commit
to dims/containerd-api-only
that referenced
this pull request
Mar 26, 2022
- Upgrade github.com/containerd/imgcrypt to prepare for typeurl upgrade (see containerd/imgcrypt#72) - Upgrade github.com/opencontainers/image-spec since imgcrypto needs at least 1.0.2. Signed-off-by: Kazuyoshi Kato <katokazu@amazon.com>
akhilerm
pushed a commit
to akhilerm/containerd-api
that referenced
this pull request
May 23, 2022
- Upgrade github.com/containerd/imgcrypt to prepare for typeurl upgrade (see containerd/imgcrypt#72) - Upgrade github.com/opencontainers/image-spec since imgcrypto needs at least 1.0.2. Signed-off-by: Kazuyoshi Kato <katokazu@amazon.com>
akhilerm
pushed a commit
to akhilerm/containerd-api
that referenced
this pull request
Jun 22, 2022
- Upgrade github.com/containerd/imgcrypt to prepare for typeurl upgrade (see containerd/imgcrypt#72) - Upgrade github.com/opencontainers/image-spec since imgcrypto needs at least 1.0.2. Signed-off-by: Kazuyoshi Kato <katokazu@amazon.com>
akhilerm
pushed a commit
to akhilerm/containerd-test
that referenced
this pull request
Feb 22, 2023
- Upgrade github.com/containerd/imgcrypt to prepare for typeurl upgrade (see containerd/imgcrypt#72) - Upgrade github.com/opencontainers/image-spec since imgcrypto needs at least 1.0.2. Signed-off-by: Kazuyoshi Kato <katokazu@amazon.com> Containerd-test-commit: e569306
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
typeurl.MarshalAny returns typeurl.Any since
containerd/typeurl#32.
Signed-off-by: Kazuyoshi Kato katokazu@amazon.com