Skip to content

Commit

Permalink
fixes need to be squashed
Browse files Browse the repository at this point in the history
Signed-off-by: fahed dorgaa <fahed.dorgaa@gmail.com>
  • Loading branch information
fahedouch committed Dec 9, 2023
1 parent 88ad6c3 commit 41e8522
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion pkg/cmd/container/create.go
Original file line number Diff line number Diff line change
Expand Up @@ -661,7 +661,7 @@ func writeCIDFile(path, id string) error {
}

// generateLogConfig creates a LogConfig for the current container store
func generateLogConfig(dataStore string, id string, logDriver string, logOpt []string, ns, hostAddress string) (logConfig logging.LogConfig, err error) {
func generateLogConfig(dataStore string, id string, logDriver string, logOpt []string, gOpt *types.GlobalCommandOptions) (logConfig logging.LogConfig, err error) {
var u *url.URL
logConfig.HostAddress = hostAddress

Check failure on line 666 in pkg/cmd/container/create.go

View workflow job for this annotation

GitHub Actions / test-unit

undefined: hostAddress

Check failure on line 666 in pkg/cmd/container/create.go

View workflow job for this annotation

GitHub Actions / cross (1.20.x)

undefined: hostAddress

Check failure on line 666 in pkg/cmd/container/create.go

View workflow job for this annotation

GitHub Actions / cross (1.21.x)

undefined: hostAddress

Check failure on line 666 in pkg/cmd/container/create.go

View workflow job for this annotation

GitHub Actions / test-integration-docker-compatibility

undefined: hostAddress

Check failure on line 666 in pkg/cmd/container/create.go

View workflow job for this annotation

GitHub Actions / test-integration-windows

undefined: hostAddress
if u, err = url.Parse(logDriver); err == nil && u.Scheme != "" {
Expand Down

0 comments on commit 41e8522

Please sign in to comment.