Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make fail (cmd/nerdctl/run_network.go:33:2: //go:build comment without // +build comment) #879

Closed
ningmingxiao opened this issue Mar 9, 2022 · 3 comments · Fixed by #881

Comments

@ningmingxiao
Copy link
Contributor

after this commit d4fb38c when use golang 1.16

cmd/nerdctl/run_network.go:33:2: //go:build comment without // +build comment
make: *** [Makefile:50:nerdctl] 
@AkihiroSuda AkihiroSuda changed the title make fail make fail (cmd/nerdctl/run_network.go:33:2: //go:build comment without // +build comment) Mar 9, 2022
@Zheaoli
Copy link
Member

Zheaoli commented Mar 9, 2022

I guess you build the nerdctl in a non-Linux platform (such as macOS/Windows/Freebsd). It will trigger a build process by using 3f1ffe2#diff-9145d3e6b0041f24b980c1854a2a3990436700a3b646438d787b7dc8d32bc294R1-R25

//go:build tag is a new feature in Go 1.17, FYI https://go.googlesource.com/proposal/+/master/design/draft-gobuild.md#abstract and https://go.dev/doc/go1.17

Maybe you can try to upgrade the Go version to 1.17.

Should we add this information to the contribute guideline? cc @AkihiroSuda

@ningmingxiao
Copy link
Contributor Author

@ningmingxiao
Copy link
Contributor Author

I guess you build the nerdctl in a non-Linux platform (such as macOS/Windows/Freebsd). It will trigger a build process by using 3f1ffe2#diff-9145d3e6b0041f24b980c1854a2a3990436700a3b646438d787b7dc8d32bc294R1-R25

//go:build tag is a new feature in Go 1.17, FYI https://go.googlesource.com/proposal/+/master/design/draft-gobuild.md#abstract and https://go.dev/doc/go1.17

Maybe you can try to upgrade the Go version to 1.17.

Should we add this information to the contribute guideline? cc @AkihiroSuda

thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants