Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove duplicate host record when update the DNS #1232

Merged
merged 1 commit into from Jul 17, 2022
Merged

Remove duplicate host record when update the DNS #1232

merged 1 commit into from Jul 17, 2022

Conversation

Zheaoli
Copy link
Member

@Zheaoli Zheaoli commented Jul 15, 2022 •
edited

Fix #1149 #1242

In the future, we may use the https://github.com/containers/dnsname project to maintain the DNS record

Signed-off-by: Zheao.Li me@manjusaka.me

@Zheaoli Zheaoli marked this pull request as draft July 15, 2022 13:24
manugupt1
manugupt1 reviewed Jul 15, 2022
View reviewed changes
pkg/testutil/compose.go Outdated Show resolved Hide resolved
@Zheaoli Zheaoli marked this pull request as ready for review July 15, 2022 14:42
@Zheaoli Zheaoli added the enhancement New feature or request label Jul 15, 2022
@Zheaoli Zheaoli added this to the vNext milestone Jul 15, 2022
@Zheaoli Zheaoli force-pushed the manjusaka/fix-1149 branch 3 times, most recently from 2c72c58 to b1152de Compare July 16, 2022 18:03
@Zheaoli
Remove duplicate host record when update the DNS
df376b8 
Signed-off-by: Zheao.Li <me@manjusaka.me>
@Zheaoli Zheaoli modified the milestones: v0.22.1, v0.22.0 Jul 16, 2022
@Zheaoli Zheaoli mentioned this pull request Jul 16, 2022
Closed
@AkihiroSuda AkihiroSuda linked an issue Jul 16, 2022 that may be closed by this pull request
Typo: :1 vs ::1 (IPv6 localhost) #1242
Closed
AkihiroSuda
AkihiroSuda approved these changes Jul 17, 2022
View reviewed changes
Copy link
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@AkihiroSuda AkihiroSuda merged commit 8e278e2 into containerd:master Jul 17, 2022
@Zheaoli Zheaoli deleted the manjusaka/fix-1149 branch July 17, 2022 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manugupt1 manugupt1 manugupt1 left review comments

@AkihiroSuda AkihiroSuda AkihiroSuda approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v0.22.0
3 participants
@Zheaoli @manugupt1 @AkihiroSuda